Question

mailing list, wiki, bug tracker?

here's one for RinEdit.cpp:

942c942
<             " OR 'y,m,d,h,m,s'(%Y,%m,%d,%H,%M,%s)\n"
---
>             " OR 'y,m,d,h,m,s'(%Y,%m,%d,%H,%M,%S)\n" 

-- FelipeNievinski - 17 Oct 2013

Answer

ALERT! If you answer a question - or have a question you asked answered by someone - please remember to edit the page and set the status to answered. The status is in a drop-down list below the edit box.

another one for Rinex3ObsHeader.cpp:
1532a1533,1545
>                // GPS L2
>                // C2 L2 S2 D2     =>  C2X L2X S2X D2X          (C2 not P2)
>                //    P2 L2 S2 D2  =>  C2P L2P S2P D2P          (P2 not C2)
>                // C2 P2 L2 S2 D2  =>  C2X C2P L2P S2P D2P      (C2 and P2)
>                if((s=="G") && (ot[1]=='2')) {
>                   string type,tc;
>                   if(ot[0] == 'C') { type = "C"; tc = "X"; }         // C2
>                   else if(ot[0] == 'P') { type = "C"; tc = "P"; }    // P2
>                   else { type = ot[0]; tc = (isPrecise ? "P":"X"); } // L2 S2 D2
>                   // shouldn't we be using e.g. tcC2LM instead of "X"?
>                   obsid = string(s+type+string(1,ot[1])+tc);
>                }
> 
1541c1554
<                if((s=="G" || s=="R") && (ot[1]=='1' || ot[1]=='2')) {
---
>                else if((s=="G" || s=="R") && (ot[1]=='1' || ot[1]=='2')) { 

-- FelipeNievinski - 17 Oct 2013

Actually, better do:
1532a1533,1545
>                // GPS L2
>                // C2 L2 S2 D2     =>  C2X L2X S2X D2X          (C2 not P2)
>                //    P2 L2 S2 D2  =>  C2W L2W S2W D2W          (P2 not C2)
>                // C2 P2 L2 S2 D2  =>  C2X C2W L2W S2W D2W      (C2 and P2)
>                if((s=="G") && (ot[1]=='2')) {
>                   string type,tc;
>                   if(ot[0] == 'C') { type = "C"; tc = "X"; }         // C2
>                   else if(ot[0] == 'P') { type = "C"; tc = "W"; }    // P2
>                   else { type = ot[0]; tc = (isPrecise ? "W":"X"); } // L2 S2 D2
>                   // shouldn't we be using e.g. tcC2LM instead of "X"?
>                   obsid = string(s+type+string(1,ot[1])+tc);
>                }
> 
1541c1554
<                if((s=="G" || s=="R") && (ot[1]=='1' || ot[1]=='2')) {
---
>                else if((s=="G" || s=="R") && (ot[1]=='1' || ot[1]=='2')) { 

-- FelipeNievinski - 17 Oct 2013

one more for Rinex3ObsHeader.cpp:
1569c1582
<                   else obsid = string(s+ot+(isPrecise ? "X" : "C"));// L5 S5 D5
---
>                   else obsid = string(s+ot+"X"); // L5 S5 D5 

-- FelipeNievinski - 18 Oct 2013

One last change for Rinex3ObsHeader.cpp, now including them all:
1525,1528d1524
<             bool isPrecise(
<                find(R2ObsTypes.begin(),R2ObsTypes.end(),"P1") != R2ObsTypes.end() ||
<                find(R2ObsTypes.begin(),R2ObsTypes.end(),"P2") != R2ObsTypes.end()
<             );
1531a1528,1543
>                bool isPrecise(
>                   find(R2ObsTypes.begin(),R2ObsTypes.end(),string("P"+ot[1])) != R2ObsTypes.end()
>                );
> 
>                // GPS L2
>                // C2 L2 S2 D2     =>  C2X L2X S2X D2X          (C2 not P2)
>                //    P2 L2 S2 D2  =>  C2W L2W S2W D2W          (P2 not C2)
>                // C2 P2 L2 S2 D2  =>  C2X C2W L2W S2W D2W      (C2 and P2)
>                if((s=="G") && (ot[1]=='2')) {
>                   string type,tc;
>                   if(ot[0] == 'C') { type = "C"; tc = "X"; }         // C2
>                   else if(ot[0] == 'P') { type = "C"; tc = "W"; }    // P2
>                   else { type = ot[0]; tc = (isPrecise ? "W":"X"); } // L2 S2 D2
>                   // shouldn't we be using e.g. tcC2LM instead of "X"?
>                   obsid = string(s+type+string(1,ot[1])+tc);
>                }
1541c1553
<                if((s=="G" || s=="R") && (ot[1]=='1' || ot[1]=='2')) {
---
>                else if((s=="G" || s=="R") && (ot[1]=='1' || ot[1]=='2')) {
1569c1581
<                   else obsid = string(s+ot+(isPrecise ? "X" : "C"));// L5 S5 D5
---
>                   else obsid = string(s+ot+"X"); // L5 S5 D5 

-- FelipeNievinski - 18 Oct 2013

isPrecise should be more precise:
1531a1528,1543
>                bool isPrecise(
>                   find(R2ObsTypes.begin(),R2ObsTypes.end(),string(s+"P"+ot[1])) != R2ObsTypes.end()
>                ); 

-- FelipeNievinski - 18 Oct 2013

RinEdit.cpp:
730,732d729
<          if(it->sign == 0 && it->ttag == CommonTime::BEGINNING_OF_TIME)
<                return 0;                              // handled above where I->0
< 
942c939
<             " OR 'y,m,d,h,m,s'(%Y,%m,%d,%H,%M,%s)\n"
---
>             " OR 'y,m,d,h,m,s'(%Y,%m,%d,%H,%M,%S)\n" 

-- FelipeNievinski - 18 Oct 2013

-- BryanParsons - 22 Oct 2013

Felipe,

Currently, we use the Sourceforge bugtracker for submission of external bugs, but this will change once our new Git developer repository is set-up and ready to use. This will also include email services for changes made to developer repositories.

Thank you for the submitted patch, which has been added it to the current developer repository.

I will send out notification emails when the Developer repository is ready for external use.

Thanks for your work and interest in the GPS Toolkit.

-- BryanParsons - 22 Oct 2013

-- FelipeNievinski - 26 Jun 2014 No such template def TMPL:DEF{PROMPT:supportquery}

Topic revision: r7 - 12 Jun 2015, UnknownUser
 

This site is powered by FoswikiCopyright © by the contributing authors. All material on this collaboration platform is the property of the contributing authors.
Ideas, requests, problems regarding Foswiki? Send feedback